Skip to content

<extend> to use audio concat#1339

Merged
mcmonkey4eva merged 2 commits intomcmonkeyprojects:masterfrom
jtreminio:extend-video-audio-concat
Apr 7, 2026
Merged

<extend> to use audio concat#1339
mcmonkey4eva merged 2 commits intomcmonkeyprojects:masterfrom
jtreminio:extend-video-audio-concat

Conversation

@jtreminio
Copy link
Copy Markdown
Contributor

@jtreminio jtreminio commented Apr 5, 2026

When using <extend>, only the audio from the first video stage is kept.

This PR adds an "Audio Concat" node(s) to append each stage's audio.

To test:

A young woman, looking at the viewer, in a sunny park. She wears a bright, thin, yellow sundress. The sun shines behind her, making her dress semi-translucent.

<video>The young woman smiles, and says "Hello, welcome to my world"
<extend:161>The young woman frowns and says, "What are you looking at?"

Generates:

CleanShot 2026-04-05 at 15 12 19@2x

Adding more:

A young woman, looking at the viewer, in a sunny park. She wears a bright, thin, yellow sundress. The sun shines behind her, making her dress semi-translucent.

<video>The young woman smiles, and says "Hello, welcome to my world"
<extend:161>The young woman frowns and says, "What are you looking at?"
<extend:161>The young woman turns around then looks back over her shoulder at the viewer before smiling and winking and saying, "Haha just kidding, gooner!"
CleanShot 2026-04-05 at 15 13 28@2x CleanShot 2026-04-05 at 15 13 50@2x

One unrelated question: vidChunks seems unused. Remove it?

@jtreminio jtreminio marked this pull request as ready for review April 5, 2026 20:18
WGNodeData ensureAttachedAudio(WGNodeData media)
{
if (media?.AttachedAudio is null
|| media.AttachedAudio.DataType == WGNodeData.DT_AUDIO
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't format like this

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{
return media;
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean up all these stray blank lines

@mcmonkey4eva mcmonkey4eva merged commit 60790d5 into mcmonkeyprojects:master Apr 7, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants