Skip to content

Fix to OFF parsing: Parser always used z=0, not actual OFF data... #2099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willend merged 1 commit into from
Aug 26, 2025
Merged

Fix to OFF parsing: Parser always used z=0, not actual OFF data... #2099

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tools/Python/mcdisplay/mantid_xml/mcdisplay.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,10 +167,10 @@ def _get_mantid_sample(self):

pixels_s2 = '''
<component type="MonNDtype-IDX_MONITOR-pix-IDX_PIXEL">
<location x="x_cp" y="y_cp" z="0" />
<location x="x_cp" y="y_cp" z="z_cp" />
</component>'''

# ['IDX_PIXEL', '0', 'NUM_PIXELS', '4', 'x_cp' , 'y_cp' , '0', '-COORD_X' , 'y_1' , '0', '-COORD_X' , 'y_2' , '0', 'COORD_X' , 'y_3' , '0', 'COORD_X' , 'y_4' , '0']
# ['IDX_PIXEL', '0', 'NUM_PIXELS', '4', 'x_cp' , 'y_cp' , 'z_cp', '-COORD_X' , 'y_1' , '0', '-COORD_X' , 'y_2' , '0', 'COORD_X' , 'y_3' , '0', 'COORD_X' , 'y_4' , '0']
# ['1009' , '0', '1009' , '4', '0.301485', '0.111419', '0', '-0.00148515', '-0.0139429', '0', '-0.00148515', '0.0128452', '0', '0.00148515', '0.0140756', '0', '0.00148515', '-0.0129778', '0']

def _get_mantid_pixels_monitors(self):
Expand Down Expand Up @@ -250,6 +250,7 @@ def wrap_join_s2_block(s2_s, monitor_name, idx_monitor):
s2 = s2.replace('IDX_MONITOR', idx_monitor)
s2 = s2.replace('x_cp', str(pix.p_cp.x))
s2 = s2.replace('y_cp', str(pix.p_cp.y))
s2 = s2.replace('z_cp', str(pix.p_cp.z))
s2_s.append(s2)

mon_txt_blocks.append('\n\n'.join(
Expand Down
Loading