feat(SF2.0/UpcomingDepartures): Show more trips for non-subway #2852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlarson
force-pushed
the
jdl/sf2.0/ud/more-bus-and-cr-trips
branch
from
57c7683 to
6eb2852
Compare
Contributor
Author
|
I marked it as "Do not merge" because it's branched off of #2850, so that one should be merged first. |
Base automatically changed from
jdl/sf2.0/ud/bus-interleave-schedule-and-prediction-data
to
main
December 23, 2025 20:42
joshlarson
force-pushed
the
jdl/sf2.0/ud/more-bus-and-cr-trips
branch
from
6eb2852 to
673c5aa
Compare
thecristen
reviewed
Dec 30, 2025
| <.remaining_service | ||
| :if={departures = @departures.ok? && @departures.result} | ||
| route_type={@route.type} | ||
| :if={departures = @stop && @departures.ok? && @departures.result} |
Collaborator
There was a problem hiding this comment.
Was departures = @stop a mistake??
Contributor
Author
There was a problem hiding this comment.
Noooo - it's probably not the best way to do it, but I was assigning departures to that I could use it in end_of_service(departures).
thecristen
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Ticket: [SF/UD] Bus + CR: Add expandable "N trips later today"