Skip to content

Conversation

@Whoops
Copy link
Contributor

@Whoops Whoops commented Jul 8, 2025

Summary of changes

Asana Ticket: 🍎 Add connection between Winthrop Ferry Terminal + Winthrop Landing

[Please include a brief description of what was changed]

@Whoops Whoops requested review from a team and firestack and removed request for a team July 8, 2025 18:42
Copy link
Member

@firestack firestack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because ~I don't know what I'm doing, I double checked the stop ids just to be sure it made sense 😅

LGTM 👍🏻


I am left with a question, that doesn't block merging but I'll put here anyway; is there something in GTFS-Schedule that would model this relationship as well? I can't find anything, and I don't see anything that would point to modeling this that is applicable in this scenario (i.e., pathways.txt and transfers.txt don't really apply here)

@Whoops
Copy link
Contributor Author

Whoops commented Jul 8, 2025

Because ~I don't know what I'm doing, I double checked the stop ids just to be sure it made sense

If you wanted to check the behavior, you can fetch the stop including the connecting stops and validate it's there. So after deploying to dev-green you can see that
https://api-dev-green.mbtace.com/stops/Boat-Winthrop?include=connecting_stops
returns Winthrop Terminal as well.

is there something in GTFS-Schedule that would model this relationship as well?

Connecting stops for whatever reason is an API-only feature. @digitalcora may have some history as to why that is, versus putting it in a GTFS extension (or setting up transfers), that's before my time, so I don't really have the history. Transfers and pathways are similar, but different ;-)

@digitalcora
Copy link
Contributor

This being an API-only feature is my fault, and no, there's no reason that has to be the case — it was just more expedient to implement this way at the time, and there were no GTFS consumers who needed the data.

is there something in GTFS-Schedule that would model this relationship as well?

No, afaik there is nothing in the standard that allows modeling this specific kind of relationship; it would have to be our own custom thing. Though to atone for my sins I've been working on a proposal for just such a thing (moving the source of this data into GTFS), which I'll share with the team shortly!

@Whoops Whoops merged commit 572724f into master Jul 9, 2025
31 checks passed
@Whoops Whoops deleted the wh-winthrop-connecting-stops branch July 9, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants