chore: Remove explicit stop overrides #873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaddox5
requested review from
a team and
sloanelybutsurely
and removed request for
a team
sloanelybutsurely
approved these changes
Apr 16, 2025
Contributor
Author
|
Sorry, was a little premature declaring this the solution. I noticed that the origin stops for the new Boat-F7 route look fine, so I'm wondering if the better solution is to actually through this override logic out. It's on its way to dev-green so will give an update on this soon. |
Contributor
Author
|
Looks like removing the overrides is the better solution here. Schedule Finder looks fine without them: |
cmaddox5
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: ⛴️ Boat-F6 becomes F6, F7, and F8
Given the number of stop sequence combos, this code helps dotcom by giving it the exact list they should display in the Schedule Finder. Updated the list for Boat-F6 and added one for Boat-F7.Boat-F6 used to serve both Winthrop and Quincy. This caused issues on dotcom's Schedule Finder due to the unusual route patterns. Now that Winthrop and Quincy operate in separate routes, we no longer need these overrides.