Add recording picker, improve recording selection logic #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbernson
force-pushed
the
choose-recording
branch
from
b53bb49 to
9ee42c1
Compare
mbernson
commented
Jan 13, 2026
| prefersHighQuality: Bool, | ||
| prefersAudio: Bool | ||
| ) -> Recording? { | ||
| // TODO: Sort according to the user's preferred language(s) |
Owner
Author
There was a problem hiding this comment.
The initially selected recording should be picked based on the user's language
mbernson
commented
Jan 13, 2026
Comment on lines
+50
to
+54
| selectedRecording = recordingChooser.choosePreferredRecording( | ||
| from: recordings, | ||
| prefersHighQuality: true, // TODO: Hook up with a preference and/or respect low data mode | ||
| prefersAudio: false // TODO: Hook up with a preference 'prefer audio' | ||
| ) |
Owner
Author
There was a problem hiding this comment.
Once we have a Settings screen in the app, it should be possible to:
- Stream the lower quality version on cellular / data saver mode
- Set the default playback rate
- Set the preferred language order (Maybe?) See also: https://developer.apple.com/documentation/avfoundation/selecting-subtitles-and-alternative-audio-tracks
- Prefer the audio recording (Maybe?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.