fix: allow group-writable files and root-owned system files in safe_source #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ource Fixes #76 The safe_source function was too restrictive: 1. Rejected files with permission 664 (group-writable) even though this is a common and safe permission for dotfiles 2. Rejected root-owned system files in /usr/share/, breaking zsh-syntax-highlighting and zsh-autosuggestions Changes: - Permission check now allows up to 775, only rejects world-writable (permissions ending in 2, 3, 6, 7 for the "other" field) - Ownership check now allows root-owned files in /usr/share/* This fixes aliases and zsh plugins not loading on freshly provisioned VMs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
/usr/share/(zsh plugins)Fixes #76
Problem
The
safe_sourcefunction was too restrictive:664(group-readable/writable) because664 > 644Changes
Permission check (line 72-80):
Ownership check (line 52-60):
/usr/share/*Test plan
/usr/share/*files are accepted/usr/shareare rejected