Skip to content

fix: add permissions to reusable workflow callers #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxrantil merged 2 commits into from
Nov 4, 2025
Merged

fix: add permissions to reusable workflow callers #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec1edd2
docs: mark issue #61 as complete and merged to master
maxrantil Nov 4, 2025
2d43f6a
fix: add permissions to reusable workflow callers
maxrantil Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/test-protect-master.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ on:
branches:
- master

permissions:
pull-requests: read
contents: read

jobs:
protect-master:
name: Test Protect Master on Push
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/test-reusable-workflows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ on:
branches:
- master

permissions:
pull-requests: read
contents: read

jobs:
# Test 1: Block AI Attribution
block-ai-attribution:
Expand Down
38 changes: 32 additions & 6 deletions SESSION_HANDOVER.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
# Session Handoff: Issue #61 - Add Automated Rollback Script

**Date**: 2025-11-04
**Issue**: #61 - Add automated rollback script for dotfiles installation
**PR**: #67 - feat: add automated rollback script (resolves #61)
**Branch**: feat/issue-61-rollback-script
**Status**: ✅ **COMPLETE - Ready for Merge**
**Issue**: #61 - Add automated rollback script for dotfiles installation ✅ **CLOSED**
**PR**: #67 - feat: add automated rollback script (resolves #61) ✅ **MERGED**
**Branch**: feat/issue-61-rollback-script (deleted)
**Status**: ✅ **COMPLETE - MERGED TO MASTER (commit 3277f6c)**

---

Expand Down Expand Up @@ -243,8 +243,34 @@ Read CLAUDE.md to understand our workflow, then continue from Issue #61 completi

---

**Status**: ✅ **Issue #61 COMPLETE - PR #67 ready for merge**
## 🎉 Final Status

**Next Session**: Monitor for approval, merge PR, verify issue closure, start next task
**Issue #61**: ✅ **CLOSED** (merged 2025-11-04T19:48:34Z)
**PR #67**: ✅ **MERGED TO MASTER** (commit `3277f6c`)
**CI/CD**: ✅ All 9 checks passed
**Feature Branch**: Deleted
**Production Status**: ✅ **DEPLOYED** (rollback.sh available in master)

### Merge Summary
- **Squash merge** completed successfully
- **780 lines added**: 196 script + 350 tests + 234 docs
- **Agent validation**: All 5 agents validated (security, devops, testing, quality, docs)
- **Security rating**: 3.5/5.0 (production ready)
- **Production readiness**: 4.2/5.0 (all blockers resolved)

---

## 📝 Startup Prompt for Next Session

```
Read CLAUDE.md to understand our workflow, then check for next priority task.

**Previous completion**: Issue #61 - Automated rollback script (✅ merged to master, commit 3277f6c)
**Context**: Dotfiles now have production-ready rollback capability with comprehensive testing and security hardening. All CI/CD checks passing.
**Reference docs**: rollback.sh, tests/rollback-test.sh (in master branch)
**Ready state**: Clean master branch, all tests passing, ready for new work

**Expected scope**: Review open issues, select next priority, create feature branch, begin implementation
```

---
Loading