refactor: eliminate test duplication in workflow (resolves #60) #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced ~240 lines of duplicated test logic in GitHub Actions workflow with a single call to the standalone test script. Changes: - Removed inline test steps from installation-test job - Now invokes tests/installation-test.sh directly - Maintains same functionality: 9 test scenarios, diagnostics on failure - Reduces workflow from ~240 lines to ~26 lines for the test job Benefits: - Single source of truth for test logic - Easier maintenance (update tests in one place) - Guaranteed consistency between CI and local testing Note: Pre-existing Docker test failure (Starship cache) is unrelated to this refactoring and also fails on master branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors
.github/workflows/shell-quality.ymlto eliminate ~240 lines of duplicated test logic by invoking the standalonetests/installation-test.shscript instead.Changes
./tests/installation-test.shwith appropriate parametersBenefits
✅ Single source of truth: Test logic only exists in
tests/installation-test.sh✅ Easier maintenance: Update tests in one place instead of two
✅ Guaranteed consistency: CI and local tests run identical code
✅ Reduced complexity: Simpler workflow configuration
Testing
Notes
Pre-existing issue: Docker test failure (Starship cache test) also fails on master branch and is unrelated to this refactoring.
Resolves
Closes #60