Conversation
Add credit_application and fund_transfer to the /event/type validation enum and corresponding test cases. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Add new /event/party enum field to specify which party is submitting the transaction. Valid values are "agent" and "customer". The field is positioned first in the event object. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Add new /payment/method enum field to specify the payment method associated with the transaction. Valid values are bank_debit, bank_redirect, bank_transfer, buy_now_pay_later, card, crypto, digital_wallet, gift_card, real_time_payment, and rewards. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for new transaction validation fields by introducing /event/party and /payment/method inputs, and expanding the /event/type validation with new values.
- Adds validation for event party (agent/customer) and payment method (multiple options like card, crypto, etc.)
- Extends event type validation with "credit_application" and "fund_transfer" values
- Updates documentation and test data to reflect the new fields
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/minfraud/validation.py | Adds validation schemas for new event/party and payment/method fields, plus new event type values |
| tests/test_validation.py | Adds comprehensive test coverage for the new validation fields |
| tests/data/full-transaction-request.json | Updates test data to include examples of the new fields |
| README.rst | Updates documentation examples to show usage of new fields |
| HISTORY.rst | Documents the new features in the changelog |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
oschwald
approved these changes
Sep 16, 2025
oschwald
deleted the
wstorey/eng-2871-eventparty-and-paymentmethod-minfraud-inputs-are-supported
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.