Update README.md Gradle and Java version instructions#654
Merged
Conversation
Replace deprecated `compile` configuration with `implementation` in the Gradle instructions. The `compile` configuration was deprecated in Gradle 3.4 and removed in Gradle 7.0. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The library requires Java 17+ as it uses Java records and the pom.xml specifies <release>17</release>. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Replace deprecated getXXX() style methods with the modern Java record accessor methods throughout all code examples. The deprecated methods are scheduled for removal in version 6.0.0. Changes include: - response.getCountry() -> response.country() - country.getIsoCode() -> country.isoCode() - country.getName() -> country.name() - response.getMostSpecificSubdivision() -> response.mostSpecificSubdivision() - location.getLatitude() -> location.latitude() - And similar changes throughout all examples Also fixed incorrect return type in Anonymous Plus example (AnonymousIpResponse -> AnonymousPlusResponse). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
oschwald
force-pushed
the
greg/eng-3756-update-gradle-instructions-in-readmemd-files
branch
from
c93f286 to
385f239
Compare
Update the City, Connection-Type, Domain, and ISP database examples to use try-with-resources for proper resource management, matching the pattern already used in the Anonymous IP, Anonymous Plus, ASN, and Enterprise examples. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
|
It's not quite part of this PR, but should Line 216 in b81dce3 |
Member
Author
|
I think we can just drop |
klp2
approved these changes
Jan 8, 2026
klp2
deleted the
greg/eng-3756-update-gradle-instructions-in-readmemd-files
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compiletoimplementationResolves ENG-3756
Test plan
<release>17</release>🤖 Generated with Claude Code