Make LAL optional #91
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
ringdown/waveforms/core.py:263
- Ensure that t0 is always provided as a float to avoid potential precision loss, and update the function documentation accordingly to reflect the new expected type.
tgps = float(t0 or self.t0)
ringdown/target.py:147
- [nitpick] Confirm that converting non-Time values to float in post_init does not introduce any precision issues; if astropy.Time objects are intended, an explicit conversion method might improve clarity.
if v is not None and not isinstance(v, Time):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make LAL an optional dependency. This requires replacing antenna pattern calculations with custom code (adapted from Jim), which has the advantage of making it Jax compatible (in case we want to sample over sky in the future).