Update index.js #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issues outlined in #5.
The solution to the Samba issue lies in providing the nlink key when directory attributes are returned. The fuse-bindings operations documentation abstract for getattr() appears to have been directly pasted into this package, and it has no nlink key, but in the fuse-bindings example code, nlink is always specified. Since Samba uses the nlink value in order to determine the character of an entry, it's mandatory to specify a proper nlink in order to use this package with Samba. Thanks to this serverfault thread for identifying the issue.
The solution to the 'ls -l' operation not permitted issue required returning fuse.ENODATA in response to a getxattr() request, rather than the fuse.EPERM that was being returned. Thanks to this stackoverflow thread for identifying the issue.
Another minor issue was also resolved in that on fast systems, there was potential for a conflict in the mounting directory filename if two files were attempted to be mounted within one millisecond.
In addition, for clarity, two unnecessarily defined error constants are removed and replaced with the full set of error definitions already available in one of the package's dependencies.
Finally, a constant is added to turn on or off debugging output.