Skip to content

Avoid UIPopoverController warning on iOS 5.1. #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hborders wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid UIPopoverController warning on iOS 5.1. #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Classes/MGSplitViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,8 +575,14 @@ - (void)reconfigureForMasterInPopover:(BOOL)inPopover
}

} else if (!inPopover && _hiddenPopoverController && _barButtonItem) {
// I know this looks strange, but it fixes a bizarre issue with UIPopoverController leaving masterViewController's views in disarray.
[_hiddenPopoverController presentPopoverFromRect:CGRectZero inView:self.view permittedArrowDirections:UIPopoverArrowDirectionAny animated:NO];
// on iOS 5.1, passing a CGRectZero here produces this following ominous message:
// -[UIPopoverController presentPopoverFromRect:inView:permittedArrowDirections:animated:]: the rect passed in to this method must have non-zero width and height. This will be an exception in a future release.
// this workaround was tested thusly:
// On iOS 4.3, CGRectZero leaves a popover afterimage before rotation, so does the code below
// On iOS 5.0, CGRectZero leaves a popover afterimage before rotation, the code below does not
// On iOS 5.1, CGRectZero leaves a popover afterimage before rotation, so does the code below
// Basically, this hack performs slightly better than the CGRectZero hack, and does not cause an ominous warning.
[_hiddenPopoverController presentPopoverFromRect:CGRectMake(-2000, -2000, 1, 1) inView:self.view permittedArrowDirections:UIPopoverArrowDirectionAny animated:NO];

// Remove master from popover and destroy popover, if it exists.
[_hiddenPopoverController dismissPopoverAnimated:NO];
Expand Down