Skip to content

Bump rand#5502

Merged
poljar merged 1 commit intomainfrom
poljar/bump-rand
Mar 31, 2026
Merged

Bump rand#5502
poljar merged 1 commit intomainfrom
poljar/bump-rand

Conversation

@poljar
Copy link
Copy Markdown
Contributor

@poljar poljar commented Aug 7, 2025

Ok, the rand bump in vodozemac will take a bit longer due to it having many more dependencies that require a rand bump as well.

In the meantime we can bump rand in the SDK.

@poljar poljar requested review from a team as code owners August 7, 2025 12:51
@poljar poljar requested review from andybalaam and stefanceriu and removed request for a team August 7, 2025 12:51
@poljar poljar marked this pull request as draft August 7, 2025 12:51
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Aug 7, 2025

Merging this PR will not alter performance

✅ 50 untouched benchmarks


Comparing poljar/bump-rand (84a5d45) with main (f0193cc)

Open in CodSpeed

@poljar poljar force-pushed the poljar/bump-rand branch from efe1f3c to 47c6731 Compare August 7, 2025 17:44
@stefanceriu stefanceriu removed their request for review October 9, 2025 05:37
@poljar poljar force-pushed the poljar/bump-rand branch from 47c6731 to 9a2f039 Compare March 30, 2026 13:48
@poljar poljar changed the title Bump our deps and rand Bump rand Mar 30, 2026
@poljar poljar marked this pull request as ready for review March 30, 2026 13:50
@poljar
Copy link
Copy Markdown
Contributor Author

poljar commented Mar 30, 2026

@andybalaam do you want to retake your look here?

@poljar poljar force-pushed the poljar/bump-rand branch from 9a2f039 to 79c6e21 Compare March 30, 2026 13:59
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.88%. Comparing base (2c6409c) to head (84a5d45).
⚠️ Report is 14 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5502      +/-   ##
==========================================
+ Coverage   89.86%   89.88%   +0.01%     
==========================================
  Files         376      376              
  Lines      103106   103098       -8     
  Branches   103106   103098       -8     
==========================================
+ Hits        92659    92667       +8     
+ Misses       6882     6869      -13     
+ Partials     3565     3562       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, looks good otherwise.

Comment thread crates/matrix-sdk-common/Cargo.toml Outdated
@poljar poljar force-pushed the poljar/bump-rand branch from 79c6e21 to 84a5d45 Compare March 31, 2026 14:19
@poljar poljar merged commit 16c1b9b into main Mar 31, 2026
54 checks passed
@poljar poljar deleted the poljar/bump-rand branch March 31, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants