Conversation
andybalaam
approved these changes
Aug 7, 2025
efe1f3c to
47c6731
Compare
47c6731 to
9a2f039
Compare
Contributor
Author
|
@andybalaam do you want to retake your look here? |
9a2f039 to
79c6e21
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5502 +/- ##
==========================================
+ Coverage 89.86% 89.88% +0.01%
==========================================
Files 376 376
Lines 103106 103098 -8
Branches 103106 103098 -8
==========================================
+ Hits 92659 92667 +8
+ Misses 6882 6869 -13
+ Partials 3565 3562 -3 ☔ View full report in Codecov by Sentry. |
andybalaam
reviewed
Mar 30, 2026
Member
andybalaam
left a comment
There was a problem hiding this comment.
One question, looks good otherwise.
79c6e21 to
84a5d45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ok, the rand bump in vodozemac will take a bit longer due to it having many more dependencies that require a
randbump as well.In the meantime we can bump
randin the SDK.