Fix volume bar border colors when using make_marketcolors#698
Open
wavebyrd wants to merge 864 commits intomatplotlib:masterfrom
Open
Fix volume bar border colors when using make_marketcolors#698wavebyrd wants to merge 864 commits intomatplotlib:masterfrom
wavebyrd wants to merge 864 commits intomatplotlib:masterfrom
Conversation
add input requirement checkout based on input reference test cat _version.py file test publish use publish v1 (instead of release/v1), and p3.x instead of p3.9 apparently @release/v1 is needed (not just @v1) now try twine publishTestPyPI and publishPyPI workflows
GitHub Actions workflows to deploy package to PyPI and TestPyPI
add status badge for mplfinance checks
Set single candle color
Minor Changes to README, to Workflow, and change Dev Status from alpha to beta
Adding edgecolors and linewidths **for `type=scatter`**
Support `marketcolors` kwarg in `make_addplot()`
As Per Suggestion All Exam Update - Used OHLCV Data Only - Calculation Within Notebook - Detail Description Calculation - Details mplfinance function used
Indicator Examples
add scratch work from issue436 and stackoverflow 75737197
move indicator examples into indicator directory
Style Enhancements, and add styles from Chandrakant
API for adding labels: `mpf.make_addplot(..., label="myLabel")`
some clarification on fork/clone workflow.
regenerate price-movements notebook, and other cleanup
When make_marketcolors() is called with custom volume colors, it updates marketcolors['volume'] but leaves marketcolors['vcedge'] pointing to the old base style value. This causes the equality check in plotting.py (mc['volume'] == mc['vcedge']) to fail, so the auto-darkening logic for volume bar edges is skipped and the old base style colors are used instead. Fix by syncing vcedge with volume whenever volume colors are changed in make_marketcolors(). Fixes matplotlib#676
Member
|
This account has been blocked from the Matplotlib organisation for automating PRs matplotlib/matplotlib#31296 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #676.
When
make_marketcolors()is called with customvolumecolors, it replacesmarketcolors['volume']with the new dict but leavesmarketcolors['vcedge']still pointing to the old base style value. Inplotting.py, the checkmc['volume'] == mc['vcedge']then evaluates toFalse, so the auto-darkening logic for volume bar edges is skipped. Instead, the old base style colors leak through as edge colors, producing the inconsistent borders described in the issue.The fix keeps
vcedgein sync withvolumewhenever volume colors are changed inmake_marketcolors(), matching the same pattern used by_validate_style()in_styledata/__init__.py.Test plan
mc['volume'] == mc['vcedge']isTrueafter the fix'inherit', andinherit=Truevolumeat all leavesvcedgeunchanged