Skip to content

Conversation

@tacaswell
Copy link
Member

  • also start using codecov

@tacaswell tacaswell added this to the v1.0 milestone Jun 4, 2016
test_cycler.py Outdated
for k, vals in zip(keys, values):
for v, v_target in zip(c, vals):
assert_equal(v[k], v_target)
v[k] == v_target
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No assert?

@tacaswell
Copy link
Member Author

thanks for catching the missing asserts.

I will squash all of these once appveyor passes.

 - also start using codecov

after_success:
coveralls
- bash <(curl -s https://codecov.io/bash)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for not pip installing codecov and just do

codecov

here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this is what the codecov site said to do but I can no longer find it (it seems those directions were conditionally shown only if you had not pushed any results).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was using the example python project as a template
template but it really doesn't matter. I am fine with this any way.

@jenshnielsen jenshnielsen merged commit e45ae7d into matplotlib:master Jun 6, 2016
@tacaswell tacaswell deleted the tst_pytest branch June 6, 2016 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants