Conversation
dpvc
left a comment
There was a problem hiding this comment.
Looks good. Slight reformatting might be nice, but not crucial.
| await page2mml('<p>$$a=b\\label{eq1}\\tag{1}$$</p><p>Refer to \\eqref{eq1}</p>')). | ||
| toMatchSnapshot(); |
There was a problem hiding this comment.
I'm wondering if the ). from the end of line 607 shouldn't be moved to the beginning of 608.
Similarly for the others. Some I think can be put on a single line, like 177+178.
There was a problem hiding this comment.
I ran prettier on the Tag.test.ts file.
As we are now using snapshots we should include the test files in our prettier/linter routine.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1444 +/- ##
==========================================
Coverage 86.49% 86.49%
==========================================
Files 340 340
Lines 86044 86044
Branches 3190 4833 +1643
==========================================
Hits 74425 74425
+ Misses 11619 11595 -24
- Partials 0 24 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR removes all occurrences of
toXmlArrayMatchfrom theTagandTextests.This now allows us to get rid of all helper functions related to XML matching, which was done via conversion to JSON. This has the advantage that
xml-jslibrary,xml2jsonconversion entirely.This completes the refactoring of the tests to use snapshots instead of customised XML comparison.