Remove warning when aliases cannot be expanded#123
Merged
mathieuprog merged 1 commit intomathieuprog:masterfrom Mar 6, 2025
Merged
Remove warning when aliases cannot be expanded#123mathieuprog merged 1 commit intomathieuprog:masterfrom
mathieuprog merged 1 commit intomathieuprog:masterfrom
Conversation
Pull Request Test Coverage Report for Build 222163f205c6c02dda2540a463b9d6e52035a5f1-PR-123Details
💛 - Coveralls |
Owner
|
What do you think of making the warning optional and in the log say someth like: if you do not wish to see this warning due to false positive, do X? |
Author
|
IMO even a flag isn't appropriate since no canonical elixir libraries do this. Since one can't determine during compilation of the file itself if a dependency will be troublesome, other libs leave it to But! It's your library, so I'm fine to add a flag if you'd prefer. Let me know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mix xreffrom a place of incomplete information. As the warning itself implies, it may be inaccurate.mix xrefto let the engineer know if there's a compile-time dep problem.