Skip to content

Conversation

@andres-erbsen
Copy link
Contributor

@andres-erbsen
Copy link
Contributor Author

  Error response from daemon: No such image: mathcomp/mathcomp-dev:coq-dev
  Error response from daemon: manifest for mathcomp/mathcomp-dev:coq-dev not found: manifest unknown: manifest unknown

@andres-erbsen
Copy link
Contributor Author

Dear maintainers,

Do you consider this PR acceptable enough to merge it so that the related stdlib change can progress?

Thanks!

@pi8027
Copy link
Member

pi8027 commented May 8, 2025

We should fix CI before merging this, but I don't have time to do it right now. Ping @math-comp/core

@andres-erbsen
Copy link
Contributor Author

andres-erbsen commented May 8, 2025

Ack. Looks like the ping did not highlight, so maybe it didn't work.

(Also note that the change itself is trivial -- unless Znumtheory.something used to refer to something other than stdlib Znumtheory, just on the versions that the CI is broken, this change is a no-op.)

@CohenCyril
Copy link
Member

CI fixed but for one CI target where the docker image is still work in progress (AFAIU). LGTM. Let's merge!

@CohenCyril
Copy link
Member

Ack. Looks like the ping did not highlight, so maybe it didn't work.

The ping did work but I guess most of the team was on vacation or something...

@CohenCyril CohenCyril merged commit d4ec06f into math-comp:master May 12, 2025
20 of 21 checks passed
@pi8027
Copy link
Member

pi8027 commented May 12, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants