Skip to content

Conversation

@drouhling
Copy link
Collaborator

This is meant to replace #119.

Some lemmas can be generalised (from pseudometric to uniform) as in #119 but this should be in another PR.

@CohenCyril
Copy link
Member

That's great!!

  • @drouhling can you add a CHANGELOG_UNRELEASED.md entry?
  • @pi8027 can you verify the new hierarchy?

@pi8027
Copy link
Member

pi8027 commented Jul 29, 2020

@CohenCyril @drouhling Done, but I didn't check the implementation by myself yet. There are 5 missing joins:

Fail check_join CompletePseudoMetric.type GRing.Lmodule.type CompleteNormedModule.type.
Fail check_join CompletePseudoMetric.type GRing.Zmodule.type CompleteNormedModule.type.
Fail check_join CompletePseudoMetric.type NormedModule.type CompleteNormedModule.type.
Fail check_join CompletePseudoMetric.type Num.NormedZmodule.type CompleteNormedModule.type.
Fail check_join CompletePseudoMetric.type PseudoMetricNormedZmodule.type CompleteNormedModule.type.

@drouhling
Copy link
Collaborator Author

drouhling commented Jul 29, 2020

* @drouhling can you add a `CHANGELOG_UNRELEASED.md` entry?

Done.

Fail check_join CompletePseudoMetric.type GRing.Lmodule.type CompleteNormedModule.type.
Fail check_join CompletePseudoMetric.type GRing.Zmodule.type CompleteNormedModule.type.
Fail check_join CompletePseudoMetric.type NormedModule.type CompleteNormedModule.type.
Fail check_join CompletePseudoMetric.type Num.NormedZmodule.type CompleteNormedModule.type.
Fail check_join CompletePseudoMetric.type PseudoMetricNormedZmodule.type CompleteNormedModule.type.

I added the missing joins.

@drouhling
Copy link
Collaborator Author

In addition to the asked modifications, I updated the misc/uniform_bigO.v file.

@pi8027
Copy link
Member

pi8027 commented Jul 29, 2020

Now the new hierarchy is correct. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants