Skip to content

Conversation

@Yosuke-Ito-345
Copy link
Contributor

Motivation for this change

I noticed that we could slightly generalize the lemma null_set_integral.
The generalized version is named null_set_integral_gen.

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@Yosuke-Ito-345
Copy link
Contributor Author

@affeldt-aist @t6s
It's a small generalization, but I'd like to use them for my formalization of actuarial mathematics.
I kindly ask for your review.

@affeldt-aist
Copy link
Member

affeldt-aist commented Dec 16, 2025

It is maybe better to replace the old lemma by its generalization rather than introduce a new lemma (I did that in the second to last commit).

@affeldt-aist affeldt-aist self-requested a review December 16, 2025 05:25
@Yosuke-Ito-345
Copy link
Contributor Author

@affeldt-aist
Thank you for the review!
I agree with replacing the old lemma.

@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Dec 16, 2025
@affeldt-aist affeldt-aist added this to the 1.15.0 milestone Dec 16, 2025
@affeldt-aist affeldt-aist merged commit d4e376f into math-comp:master Dec 16, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ✨ This issue/PR is about adding new features enhancing the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants