Skip to content

Conversation

@Tragicus
Copy link
Collaborator

Motivation for this change

#1300 was merged between the last CI of rocq-prover/rocq#19611 and it being merged. It so happens that the latter PR breaks the former, so this fixes it.
N.B. I am confused that there is a TopologicalLmodule structure but nbhs0N_subproof is defined with a topologicalType with a GRing.Lmodule class. @mkerjean pointed me to #1300 (comment). Would it make sense to redefine the section in order to use TopologicalLmodule.type.

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Reminder to reviewers

@proux01
Copy link
Collaborator

proux01 commented Nov 19, 2024

Adapt to mc#19611

I guess it's Coq? (commit title too)

@Tragicus Tragicus changed the title Adapt to mc#19611 Adapt to coq#19611 Nov 19, 2024
@Tragicus
Copy link
Collaborator Author

Yes, thanks.

@pi8027
Copy link
Member

pi8027 commented Nov 19, 2024

N.B. I am confused that there is a TopologicalLmodule structure but nbhs0N_subproof is defined with a topologicalType with a GRing.Lmodule class. @mkerjean pointed me to #1300 (comment). Would it make sense to redefine the section in order to use TopologicalLmodule.type.

+1

@mkerjean mkerjean mentioned this pull request Nov 19, 2024
2 tasks
@Tragicus
Copy link
Collaborator Author

As discussed here, I changed the context in which a few lemmas are declared, along with some typing annotations.

@affeldt-aist affeldt-aist merged commit 33c087a into math-comp:master Nov 20, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants