-
Notifications
You must be signed in to change notification settings - Fork 64
coq-mathcomp-reals package #1349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b09d4e9 to
8bde5b3
Compare
|
Should we also consider a package for |
8bde5b3 to
c5b4478
Compare
This PR puts them in reals (sorry, I forgot the files in the top post description) but we could indeed make it an independent package, that would only depend on reals. No strong opinion on my side, altreals really feels to me like a never finished attempt not very useful in its current state, so I don't really care where it goes. If one day it provides an actual instance of realType, I guess we would be happy to have it in reals? |
I see. I should have double-checked the diff.
Since there are admitted facts in altreal, that could be a nice way to quarantine them.
I am not sure there is such a plan. I am wondering whether Rstruct.v and Rstruct_topology.v should go together. |
c5b4478 to
7c2e6e6
Compare
Ok done
Ok
I'd like to avoid that. A user wanting only reals but also working with Stdlib would then have to compile the entire Analysis. |
ac11127 to
17a7e11
Compare
3930028 to
132ff3f
Compare
|
So this is ready. Let me know if / when we merge so that I can update the nix toolbox at about the same time to minimize disruptions in CIs. |
affeldt-aist
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The packages all make sense, dependencies have been reduced, there is even a packager to facilitate releases, and cherry on top the nix expertise. This is great. Thank you.
|
For the changelog, the list up of the file movements summarized in the first item of the conversation is almost enough a documentation for the user I think. |
132ff3f to
76e5d2d
Compare
|
Changelog done |
Following the package split in math-comp/analysis#1349
Following the package split in math-comp/analysis#1349
Following the package split in math-comp/analysis#1349
Motivation for this change
New packages:
Following discussions during last meeting https://github.com/math-comp/analysis/wiki/2024-10-10-Meeting
This is probably best inspected by commit.
Depends on: #1347 and #1348
If we agree on the principle, I'll do the changelog and packages / CI work.
Checklist
CHANGELOG_UNRELEASED.md[ ] added corresponding documentation in the headersReference: How to document
Reminder to reviewers