Skip to content

Conversation

@esoteric-ephemera
Copy link
Contributor

@esoteric-ephemera esoteric-ephemera commented Nov 10, 2025

  • Mostly superseded by #558 In pytest==9.0, raising a unitest.SkipTest no longer allows a test to be skipped, but marks the test as failed, see issue here. Adding workarounds so that fireworks doesn't rely on older pytest versions + should still work with just unittest architecture
  • Remove deprecated utcnow in favor of recommended and more verbose datetime.datetime.now(datetime.timezone.utc)
  • Bump some test versions to test realistic behavior

@esoteric-ephemera esoteric-ephemera changed the title Pytest 9 CI issues [WIP] Pytest 9 CI issues Nov 10, 2025
@esoteric-ephemera esoteric-ephemera changed the title [WIP] Pytest 9 CI issues Pytest 9 CI issues Nov 10, 2025
@esoteric-ephemera
Copy link
Contributor Author

Guess you beat me to it @janosh haha! Not sure the syntax for createUser / dropUser changed, or if the pymongo docs are out of date. The fireworks syntax matches the pymongo docs

Still some fixes that will be relevant as time goes on here, @computron,

@computron computron merged commit d56640c into materialsproject:main Nov 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants