[BREAKING] Change default thermo type in get_entries_in_chemsys#1074
Open
esoteric-ephemera wants to merge 2 commits intomainfrom
Open
[BREAKING] Change default thermo type in get_entries_in_chemsys#1074esoteric-ephemera wants to merge 2 commits intomainfrom
esoteric-ephemera wants to merge 2 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1074 +/- ##
==========================================
- Coverage 86.82% 86.68% -0.14%
==========================================
Files 47 47
Lines 2680 2682 +2
==========================================
- Hits 2327 2325 -2
- Misses 353 357 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #993 by defaulting to the
GGA_GGA+U_R2SCANhull as the default thermo type. This is consistent with our website's behavior and will be more relevant as we start building in the recompute data