Cometdog/multiplatform low hanging fruit#65
Conversation
| // into Tinylog | ||
|
|
||
| val directoryForLogs: File = applicationGraph.getFileLoggingController().getLogFolder() | ||
| val directoryForLogs: File = File(applicationGraph.getFileLoggingController().getLogFolder().toString()) |
There was a problem hiding this comment.
I'm not in love with handling File creation at the point-of-use but I think until iOS worms its way into the modules more, using paths from Okio is probably the most seamless approach before getting into expectations-actuals for platforms.
There was a problem hiding this comment.
I think logging would have to be ripped out anyways, current system is very Android-specific.
| // into Tinylog | ||
|
|
||
| val directoryForLogs: File = applicationGraph.getFileLoggingController().getLogFolder() | ||
| val directoryForLogs: File = File(applicationGraph.getFileLoggingController().getLogFolder().toString()) |
There was a problem hiding this comment.
I think logging would have to be ripped out anyways, current system is very Android-specific.
|
build logic changes look good to me, but Immutable changes really are not necessary as the annotation comes from the multiplatform artifact. |
CometDog
force-pushed
the
cometdog/multiplatform-low-hanging-fruit
branch
2 times, most recently
from
6fea345 to
dd1f531
Compare
|
I've put Stable and Immutable back, removed the jvm target as it is not necessary as far as I can tell at this exact moment, removed the conditional around including iOS targets, and rebased against master. I also now understand more the org.jetbrains.compose./androidx.compose. situation further for my other branch which does mostly the same thing just for android-only modules so that clarity if good to have from here. |
|
Is the lint error in the build something I'm to be concerned with? If so I can look at it. Truthfully I did not run lint before and after to know if I caused it because I'm an evil villain |
|
Yes, until lint is resolved, we cannot merge |
CometDog
force-pushed
the
cometdog/multiplatform-low-hanging-fruit
branch
from
dd1f531 to
4f71866
Compare
|
One thing: please stop force pushing on every change. It makes it hard to track the changes from a reviewer's standpoint (and in the future). Just regular commits are fine. |
|
I've fixed the two annoying issues that were caused by bugs in the https://github.com/autonomousapps/dependency-analysis-gradle-plugin. The rest should be fairly simple to fix. |
In these cases what would you rather. I can push junk commits that are just fixes or fixups that require a rebase and re-approval on squash unless approval is retained across unchanged changesets |
|
I would rather do without any rebasing at all. It's a nice feature when working alone on a branch, but it becomes a pain when working with multiple people. |
|
@CometDog what is the status of this? |
2 participants
I don't have an Android phone to test on so testing is purely through the emulator, which means I don't have a connected watch but from purely running through the app, I see no regressions compared to a build without these changes.