Create sorted_variables #3145
Create sorted_variables #3145
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
I am requesting changes to your solution. You've done a great job correctly identifying which data types are mutable and immutable. However, the solution incorrectly includes the variables a, b, c, and d, which were only provided as an example in the task description. Please remove these four variables from the app/main.py file and from the lists within the sorted_variables dictionary to meet the requirements.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work! You've correctly categorized all the variables as mutable or immutable, and the data structure perfectly meets the task requirements. I am approving your solution as the core logic is solid.
Just a heads-up, the automated flake8 style check failed due to a couple of minor formatting issues in app/main.py. Specifically, there's an indentation error with a closing bracket (E124) and an extra blank line at the end of the file (W391). Please review the linter's feedback to fix these for future submissions. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.