Add task solution#2152
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great work on this task! Your code correctly fetches the data and performs the necessary calculations. However, one change is needed to fully meet the requirements.
The task specifies that the calculated numbers should match the numeric style of the original population data, which are whole numbers. Your calculated average is currently being displayed with decimal places.
To fix this, please round the average value to the nearest whole number before converting it to a string with toLocaleString. You can use Math.round() for this. Once that's updated, this will be ready to go!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| const average = total / populations.length; | ||
|
|
||
| const normalizeTotal = total.toLocaleString('en-US'); | ||
| const normalizeAverage = average.toLocaleString('en-US'); |
There was a problem hiding this comment.
Good job using toLocaleString for formatting! However, the calculated average can be a floating-point number, while the requirement is to match the 'same numeric style as populations presented', which are whole numbers. Consider rounding the average value (e.g., with Math.round()) before converting it to a string to meet this requirement.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work! You've successfully addressed the feedback from the previous review by rounding the average population. Your solution is clean, efficient, and now fully meets all the requirements of the task. I am happy to approve your submission. Great job!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
DEMO LINK