-
Notifications
You must be signed in to change notification settings - Fork 0
✨feat: CustomMissionCell 삭제 기능 추가 #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -32,6 +32,8 @@ class MissionViewController: UIViewController { | |||||
| private let pauseResumeMissionSubject = PublishSubject<UUID>() | ||||||
| private let stopMissionSubject = PublishSubject<UUID>() | ||||||
|
|
||||||
| private let deleteMissionSubject = PublishSubject<MissionPayload>() | ||||||
|
|
||||||
| private lazy var dataSource: UICollectionViewDiffableDataSource<MissionSection, MissionItem> = { | ||||||
| let dataSource = UICollectionViewDiffableDataSource<MissionSection, MissionItem>(collectionView: mainView.collectionView) {[weak self] collectionView, indexPath, itemIdentifier in | ||||||
| guard let self else { fatalError("Error: self is nil") } | ||||||
|
|
@@ -171,6 +173,18 @@ extension MissionViewController { | |||||
| }) | ||||||
| .disposed(by: disposeBag) | ||||||
| */ | ||||||
|
|
||||||
| deleteMissionSubject | ||||||
| .subscribe(onNext: { [weak self] mission in | ||||||
| guard let self else { return } | ||||||
| do { | ||||||
| try self.coreDataManager.deleteMissionEntity(of: mission.id) | ||||||
| self.initialLoadSubject.onNext(()) | ||||||
| } catch { | ||||||
| self.showErrorAlert(error: .saveFailed) | ||||||
| } | ||||||
| }) | ||||||
| .disposed(by: disposeBag) | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
|
|
@@ -181,6 +195,19 @@ extension MissionViewController { | |||||
| mainView.collectionView.register(CustomMissionCell.self, forCellWithReuseIdentifier: CustomMissionCell.id) | ||||||
| mainView.collectionView.register(MissionHeaderView.self, forSupplementaryViewOfKind: UICollectionView.elementKindSectionHeader, withReuseIdentifier: MissionHeaderView.id) | ||||||
| } | ||||||
|
|
||||||
| func collectionView(_ collectionView: UICollectionView, contextMenuConfigurationForItemAt indexPath: IndexPath, point: CGPoint) -> UIContextMenuConfiguration? { | ||||||
| guard let item = dataSource.itemIdentifier(for: indexPath), | ||||||
| case .customMission(let mission) = item else { return nil } | ||||||
|
|
||||||
| return UIContextMenuConfiguration(identifier: nil, previewProvider: nil) { _ in | ||||||
| let delete = UIAction(title: "삭제", image: UIImage(systemName: "trah.fill"), attributes: .destructive) { [weak self] _ in | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
References
|
||||||
| self?.deleteMissionSubject.onNext(mission) | ||||||
| } | ||||||
| return UIMenu(title: "",children: [delete]) | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| } | ||||||
|
|
||||||
| extension MissionViewController: UICollectionViewDelegate { | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleteMissionEntity(of:)메서드는.saveFailed외에도 다양한CoreDataError를 발생시킬 수 있습니다. 예를 들어,fetchMissionEntity가 실패하면.loadFailed나.empty오류가 발생할 수 있습니다. 현재catch블록은 모든 오류를.saveFailed로 처리하여 사용자에게 부정확한 오류 정보를 보여줄 수 있습니다. 발생한 실제 오류를 전달하여 더 정확한 피드백을 제공해야 합니다.References