Skip to content

♻️ refactor: MusicResponse, PodcastResponse 제너릭으로 변환 및 사용 메서드 변경#22

Open
ybin4548 wants to merge 2 commits into
mastarTrack:main_ybfrom
ybin4548:refact
Open

♻️ refactor: MusicResponse, PodcastResponse 제너릭으로 변환 및 사용 메서드 변경#22
ybin4548 wants to merge 2 commits into
mastarTrack:main_ybfrom
ybin4548:refact

Conversation

@ybin4548
Copy link
Copy Markdown
Collaborator

♻️ refactor: MusicResponse, PodcastResponse 제너릭으로 변환 및 사용 메서드 변경

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

MusicResponse와 PodcastResponse를 제네릭 타입인 iTunesResponse로 통합하고, 중복되던 검색 로직을 search 메서드로 추출하여 리팩토링한 점이 좋습니다. 코드의 재사용성이 향상되었네요. 다만, 새로 추가된 search 메서드에 몇 가지 수정이 필요한 부분이 있어 리뷰 남깁니다.

Comment thread challenge/challenge/ViewModel/SearchViewModel.swift Outdated
Comment thread challenge/challenge/ViewModel/SearchViewModel.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant