Skip to content

Remove duplicate CMake in modules implementation#303

Open
davidstone wants to merge 1 commit into
marzer:masterfrom
davidstone:patch-1
Open

Remove duplicate CMake in modules implementation#303
davidstone wants to merge 1 commit into
marzer:masterfrom
davidstone:patch-1

Conversation

@davidstone
Copy link
Copy Markdown

It looks like two different approaches to the same problem got committed to this file. Remove the more complicated approach and keep the simpler approach. This fixes CMake warnings about the same source file appearing multiple times.

Pre-merge checklist

  • I've read [CONTRIBUTING.md]
  • I've rebased my changes against the current HEAD of origin/master (if necessary)
  • I've added new test cases to verify my change
  • I've regenerated toml.hpp ([how-to])
  • I've updated any affected documentation
  • I've rebuilt and run the tests with at least one of:
    • Clang 8 or higher
    • GCC 8 or higher
    • MSVC 19.20 (Visual Studio 2019) or higher
  • I've added my name to the list of contributors in README.md

It looks like two different approaches to the same problem got committed to this file. Remove the more complicated approach and keep the simpler approach. This fixes CMake warnings about the same source file appearing multiple times.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant