Fix reinterpret_cast usage#299
Merged
Merged
Conversation
marzer
requested changes
May 8, 2026
| __pragma(warning(disable : 4711)) /* function selected for automatic expansion */ \ | ||
| __pragma(warning(disable : 4820)) /* N bytes padding added */ \ | ||
| __pragma(warning(disable : 4946)) /* reinterpret_cast used between related classes */ \ | ||
| __pragma(warning(disable : 4946)) /* static_cast used between related classes */ \ |
Owner
There was a problem hiding this comment.
This comment is now incorrect (I guess search and replace?) but actually this warning suppression should be removed entirely, as it was the right diagnostic for what your PR is addressing.
Co-authored-by: Mark Gillard <mark.gillard@outlook.com.au>
Co-authored-by: Mark Gillard <mark.gillard@outlook.com.au>
Co-authored-by: Mark Gillard <mark.gillard@outlook.com.au>
ShereeMorphett
commented
May 8, 2026
Contributor
Author
ShereeMorphett
left a comment
ShereeMorphett
left a comment
There was a problem hiding this comment.
Fixed requested changes
marzer
approved these changes
May 8, 2026
Owner
|
Thanks 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change do?
Replace reinterpret_cast with static_cast for node hierarchy downcasts.
Is it related to an exisiting bug report or feature request?
Pre-merge checklist
origin/master(if necessary)