Skip to content

Conversation

@moretti
Copy link
Member

@moretti moretti commented Feb 26, 2018

The proposed solution in JedWatson#64 to remove findDOMNode is buggy, breaks the component API and doesn't seem to work properly with stateless components.

Revert to use findDOMNode instead.

I know that dan doesn't like it, but it's still part the public API and it's not deprecated.

@moretti moretti requested a review from a team February 26, 2018 17:15
@mallison mallison merged commit f30168d into master Feb 26, 2018
@mallison mallison deleted the use-find-dom-node branch February 26, 2018 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants