Upgrade deps and use Jest #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moretti
force-pushed
the
use-jest
branch
6 times, most recently
from
8ba5f36 to
a4f4e1f
Compare
moretti
commented
Feb 21, 2018
| const experimentName = UUID.v4(); | ||
| describe('Weighted Experiment', () => { | ||
| xit('should choose a weighted variants', () => { | ||
| // TODO: this test work, but it's incredibly slow |
Member
Author
There was a problem hiding this comment.
This test is currently skipped, because it takes ages to run, as it has to render the experiment 1000 times to measure the standard deviation.
Perhaps there's a better way of doing that. 🤔
ghost
approved these changes
Feb 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the existing Mocha and Karma test to use a modern version of Jest.