fix: recognize iso8601 and rfc822 as valid DateTime format aliases#1013
Merged
sloria merged 2 commits intomarshmallow-code:devfrom Feb 13, 2026
Conversation
Fixes marshmallow-code#970 Marshmallow's DateTime field accepts both short and long format names (iso/iso8601, rfc/rfc822) in its SERIALIZATION_FUNCS and DESERIALIZATION_FUNCS. However, datetime2properties only checked for the short forms, causing iso8601 and rfc822 to fall through to the custom format branch producing incorrect OpenAPI output (missing date-time format for iso8601, missing pattern/example for rfc822). This adds the long-form aliases to the existing checks so they produce the same OpenAPI properties as their short-form equivalents. Tests added for both iso8601 and rfc822 format values.
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #970
Marshmallow's DateTime field accepts both short and long format names
(iso/iso8601, rfc/rfc822) in its SERIALIZATION_FUNCS and
DESERIALIZATION_FUNCS. However, datetime2properties only checked for
the short forms, causing iso8601 and rfc822 to fall through to the
custom format branch — producing incorrect OpenAPI output.
Added the long-form aliases to the existing checks and tests for both.
Full test suite: 598 passed, 6 skipped.