Skip to content

Support for Swift 4.2 #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
algonrey wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Support for Swift 4.2 #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca20c19
Support for Swift 4.2
Nov 13, 2018
49fe558
Change deprecated methods for viewcontrollers
May 30, 2019
6470fa5
Update version
May 30, 2019
9c43bf3
Change name to submit new pod
Jun 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion FileBrowser.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@
TargetAttributes = {
344169531C67812400B93D28 = {
CreatedOnToolsVersion = 7.2.1;
LastSwiftMigration = 0900;
LastSwiftMigration = 1010;
};
3441695D1C67812400B93D28 = {
CreatedOnToolsVersion = 7.2.1;
Expand Down Expand Up @@ -477,6 +477,7 @@
PRODUCT_NAME = "$(TARGET_NAME)";
SKIP_INSTALL = YES;
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
SWIFT_VERSION = 4.2;
};
name = Debug;
};
Expand All @@ -495,6 +496,7 @@
PRODUCT_BUNDLE_IDENTIFIER = com.roymarmelstein.FileBrowser;
PRODUCT_NAME = "$(TARGET_NAME)";
SKIP_INSTALL = YES;
SWIFT_VERSION = 4.2;
};
name = Release;
};
Expand Down
8 changes: 8 additions & 0 deletions FileBrowser.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>IDEDidComputeMac32BitWarning</key>
<true/>
</dict>
</plist>
4 changes: 2 additions & 2 deletions FileBrowser/FileListSearch.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ extension FileListViewController: UISearchBarDelegate, UISearchControllerDelegat

// MARK: UISearchControllerDelegate
func willPresentSearchController(_ searchController: UISearchController) {
self.tableView.contentInset = UIEdgeInsetsMake(20, 0, 0, 0)
self.tableView.contentInset = UIEdgeInsets.init(top: 20, left: 0, bottom: 0, right: 0)
}

func willDismissSearchController(_ searchController: UISearchController) {
self.tableView.contentInset = UIEdgeInsetsMake(0, 0, 0, 0)
self.tableView.contentInset = UIEdgeInsets.init(top: 0, left: 0, bottom: 0, right: 0)
}

// MARK: UISearchBarDelegate
Expand Down
6 changes: 3 additions & 3 deletions FileBrowser/FileListTableView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,13 +86,13 @@ extension FileListViewController: UITableViewDataSource, UITableViewDelegate {
return collation.section(forSectionIndexTitle: index)
}

func tableView(_ tableView: UITableView, commit editingStyle: UITableViewCellEditingStyle, forRowAt indexPath: IndexPath) {
if (editingStyle == UITableViewCellEditingStyle.delete) {
func tableView(_ tableView: UITableView, commit editingStyle: UITableViewCell.EditingStyle, forRowAt indexPath: IndexPath) {
if (editingStyle == UITableViewCell.EditingStyle.delete) {
let selectedFile = fileForIndexPath(indexPath)
selectedFile.delete()

prepareData()
tableView.reloadSections([indexPath.section], with: UITableViewRowAnimation.automatic)
tableView.reloadSections([indexPath.section], with: UITableView.RowAnimation.automatic)
}
}

Expand Down
8 changes: 4 additions & 4 deletions FileBrowser.podspec → SwiftFileBrowser.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
#

Pod::Spec.new do |s|
s.name = "FileBrowser"
s.version = "1.0.0"
s.name = "SwiftFileBrowser"
s.version = "1.0.1"
s.summary = "Powerful iOS file browser in Swift."

# This description is used to generate tags and improve search results.
Expand All @@ -20,11 +20,11 @@ Pod::Spec.new do |s|
A Swift file browser for iOS. Supports QuickLook, search and 3D touch.
DESC

s.homepage = "https://github.com/marmelroy/FileBrowser"
s.homepage = "https://github.com/algonrey/FileBrowser"
# s.screenshots = "www.example.com/screenshots_1", "www.example.com/screenshots_2"
s.license = 'MIT'
s.author = { "Roy Marmelstein" => "marmelroy@gmail.com" }
s.source = { :git => "https://github.com/marmelroy/FileBrowser.git", :tag => s.version.to_s, :submodules => true}
s.source = { :git => "https://github.com/algonrey/FileBrowser.git", :tag => s.version.to_s, :submodules => true}
s.social_media_url = "http://twitter.com/marmelroy"

s.ios.deployment_target = '8.0'
Expand Down