-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
fix(AutocompleteInput): expose renderInput in TypeScript props #11131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
AarishMansur
wants to merge
63
commits into
marmelab:next
from
AarishMansur:fix-autocomplete-renderinput-types
Closed
fix(AutocompleteInput): expose renderInput in TypeScript props #11131
AarishMansur
wants to merge
63
commits into
marmelab:next
from
AarishMansur:fix-autocomplete-renderinput-types
+1,349
−505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/core) from 8.6.11 to 8.6.15. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v8.6.15/code/core) --- updated-dependencies: - dependency-name: storybook dependency-version: 8.6.15 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
…rn/storybook-8.6.15 Bump storybook from 8.6.11 to 8.6.15
[Doc] Update `<DatagridAG>` docs following ra-datagrid-ag 7.0.0 release
…passed-to-reset Fix `<Form>` ignores resetOptions when record changes
[chore] Fix security vulnerabilities in `qs` and `systeminformation`
[Doc] Clarify validation prop usage on ReferenceInput/ReferenceArrayInput
Bumps [react-router](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router) from 6.28.1 to 6.30.2. - [Release notes](https://github.com/remix-run/react-router/releases) - [Changelog](https://github.com/remix-run/react-router/blob/main/CHANGELOG.md) - [Commits](https://github.com/remix-run/react-router/commits/react-router@6.30.2/packages/react-router) --- updated-dependencies: - dependency-name: react-router dependency-version: 6.30.2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…rn/react-router-6.30.2 Bump react-router from 6.28.1 to 6.30.2
…alidation [Doc] Fix `Validation` section position
…3ebb5cab47ad2804d9cc58e0cf0792a478 [Doc] Update RA Core EE documentation
…n-store-documentation [Doc] Update `<AutoPersistInStore>` documentation
Bumps [devalue](https://github.com/sveltejs/devalue) from 5.5.0 to 5.6.2. - [Release notes](https://github.com/sveltejs/devalue/releases) - [Changelog](https://github.com/sveltejs/devalue/blob/main/CHANGELOG.md) - [Commits](sveltejs/devalue@v5.5.0...v5.6.2) --- updated-dependencies: - dependency-name: devalue dependency-version: 5.6.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
[Doc] Update link to marmelab blog
…erver Data Provider. - add missing deleteMany usages in packages/ra-data-json-server/src/index.ts and packages/ra-data-json-server/README.md. - reformat requests table in packages/ra-data-json-server/README.md
…r-delete-many-in-docs docs: Add deleteMany method to README and source code docs for json-server Data Provider.
…l-order [Fix] Keep `ColumnsSelector` search input fixed above menu list
[Fix] Stabilize flaky tests
'Longitude' used as placeholder in both places - one shuold be 'latitude'.
Fix: Placeholder Inputs.md
Bumps [diff](https://github.com/kpdecker/jsdiff) from 5.2.0 to 5.2.2. - [Changelog](https://github.com/kpdecker/jsdiff/blob/master/release-notes.md) - [Commits](kpdecker/jsdiff@v5.2.0...v5.2.2) --- updated-dependencies: - dependency-name: diff dependency-version: 5.2.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…rn/diff-5.2.2 Bump diff from 5.2.0 to 5.2.2
This should silence a development-only dependabot alert.
[Chore] Update Cypress
Bumps [lodash-es](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.21...4.17.23) --- updated-dependencies: - dependency-name: lodash-es dependency-version: 4.17.23 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.21...4.17.23) --- updated-dependencies: - dependency-name: lodash dependency-version: 4.17.23 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…rn/lodash-4.17.23 Bump lodash from 4.17.21 to 4.17.23
…rn/lodash-es-4.17.23 Bump lodash-es from 4.17.21 to 4.17.23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
AutocompleteInputsupports therenderInputprop at runtime via the underlying MUI Autocomplete component, but this prop is not exposed in the TypeScript definition ofAutocompleteInputPropsAs a result TypeScript users cannot pass
renderInputwithout losing type safety or relying on implicit typing.Solution
This PR exposes the
renderInputprop in theAutocompleteInputTypeScript interface by reusing the corresponding type from MUI’sAutocompletePropsThere is no runtime behavior change this only aligns the TypeScript definition with the existing supported API.How To Test
Use
AutocompleteInputwith arenderInputprop in a TypeScript project.Verify that TypeScript accepts the prop without errors.
Run the test suite (
yarn test)to ensure no regressions are introduced.Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a featureAlso, please make sure to read the contributing guidelines.