Add JPEG 2000 mime types #82
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- As per RFC3745
markwhitaker
requested changes
Dec 30, 2025
Owner
There was a problem hiding this comment.
@CraigN Thanks for the PR! And apologies for missing it when you first submitted. Also thanks for your clean commit and for adding tests.
There's just one change I'd like to request: the existing constants are all named to match the MIME type value rather than being descriptive, so please can you rename these accordingly? For example, MimeType.Image.Jpeg2000 should be MimeType.Image.Jp2.
Many thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for JPEG 2000 image and video mime types as per RFC3745.