PDP-908: Remove leading and trailing xquery comments from copyright h… #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the copyright header validation logic to support XQuery-style comment syntax by adding support for (: and :) comment delimiters alongside existing HTML and C-style comment patterns.
Changes:
- Added XQuery trailing comment terminator
:)to the pattern matching - Added XQuery leading comment opener
(:to the pattern matching
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| for line in lines[:20]: | ||
| # Remove common leading comment characters and whitespace (including HTML <!-- starts) | ||
| cleaned_line = re.sub(r'^[\s\*#\/]*(?:<!--)?', '', line).strip() | ||
| # Remove common leading comment characters and whitespace (including HTML <!-- starts and XQuery (: ) |
There was a problem hiding this comment.
Missing closing parenthesis in comment. Should be 'XQuery (: )'.
Suggested change
| # Remove common leading comment characters and whitespace (including HTML <!-- starts and XQuery (: ) | |
| # Remove common leading comment characters and whitespace (including HTML <!-- starts and XQuery comments starting with '(:' and ending with ':)') |
jsvoboda-prgs
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eader