MLE-29898 MLE-29899: [develop-11.3] fix ResourceSequence leak in ContentOutputFormat initialize() and null pointer dereference in NodeImpl.isEqualNode() (Backport)

[vshaniga]

These changes have already been validated on the develop branch in the PR: #605

Tests

• Ran unit tests → All passed
• Ran 06mlcp test suite → No regression failures were found

[Copilot]

Pull request overview

Backport of two fixes from develop to the develop-11.3 line: ensuring XCC ResultSequence resources are closed during ContentOutputFormat.initialize() to prevent connection/socket leaks, and correcting NodeImpl.isEqualNode() logic to avoid a null dereference and to perform proper equality checks.

Changes:

• Wrap session.submitRequest(query) result handling in ContentOutputFormat.initialize() with try/finally to always close() the ResultSequence.
• Fix NodeImpl.isEqualNode() by using the correct hasAttributes()/hasChildNodes() guards and negating child/attribute equality checks.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/main/java/com/marklogic/mapreduce/ContentOutputFormat.java	Ensures ResultSequence is closed in initialize() and adjusts surrounding initialization flow.
src/main/java/com/marklogic/dom/NodeImpl.java	Corrects node equality logic to avoid NPEs and produce correct results.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.