Skip to content

Fix #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ueen wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions SQReorderableStackView/Classes/SQReorderableStackView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ public protocol SQReorderableStackViewDelegate {
@objc optional func stackView(_ stackView: SQReorderableStackView, didDragToReorderInForwardDirection forward: Bool, maxPoint: CGPoint, minPoint: CGPoint)

/// didReorderArrangedSubviews - called when reordering ends only if the selected subview's index changed during reordering
@objc optional func stackViewDidReorderArrangedSubviews(_ stackView: SQReorderableStackView)
@objc optional func stackViewDidReorderArrangedSubviews(_ stackView: SQReorderableStackView, startIndex: Int, endIndex: Int)

/// didEndReordering - called when reordering ends
@objc optional func stackViewDidEndReordering(_ stackView: SQReorderableStackView)
@objc optional func stackViewDidEndReordering(_ stackView: SQReorderableStackView, startIndex: Int, endIndex: Int)

/// called when reordering is cancelled
@objc optional func stackViewDidCancelReordering(_ stackView: SQReorderableStackView)
Expand All @@ -46,7 +46,7 @@ public class SQReorderableStackView: UIStackView, UIGestureRecognizerDelegate {
}

/// The delegate for reordering.
public var reorderDelegate: SQReorderableStackViewDelegate?
public weak var reorderDelegate: SQReorderableStackViewDelegate?

fileprivate var longPressGRS = [UILongPressGestureRecognizer]()

Expand Down Expand Up @@ -257,9 +257,9 @@ public class SQReorderableStackView: UIStackView, UIGestureRecognizerDelegate {
reordering = false
endIndex = indexOfArrangedSubview(actualView)
if startIndex != endIndex {
reorderDelegate?.stackViewDidReorderArrangedSubviews?(self)
reorderDelegate?.stackViewDidReorderArrangedSubviews?(self, startIndex: startIndex, endIndex: endIndex)
}
reorderDelegate?.stackViewDidEndReordering?(self)
reorderDelegate?.stackViewDidEndReordering?(self, startIndex: startIndex, endIndex: endIndex)

case .cancelled:
reorderDelegate?.stackViewDidCancelReordering?(self)
Expand All @@ -268,8 +268,22 @@ public class SQReorderableStackView: UIStackView, UIGestureRecognizerDelegate {

fileprivate func prepareForReordering() {

//hide shadow
let didClip = actualView.clipsToBounds
actualView.clipsToBounds = true

// Configure the temporary view
temporaryView = actualView.snapshotView(afterScreenUpdates: true)

//reset actualView and copy shadow
actualView.clipsToBounds = didClip
temporaryView.layer.shadowRadius = actualView.layer.shadowRadius
temporaryView.layer.shadowPath = actualView.layer.shadowPath
temporaryView.layer.shadowColor = actualView.layer.shadowColor
temporaryView.layer.shadowOffset = actualView.layer.shadowOffset
temporaryView.layer.shadowOpacity = actualView.layer.shadowOpacity
temporaryView.layer.cornerRadius = actualView.layer.cornerRadius

temporaryView.frame = actualView.frame
finalReorderFrame = actualView.frame
addSubview(temporaryView)
Expand Down