Skip to content

Conversation

@vsreekanth-stripe
Copy link
Contributor

@vsreekanth-stripe vsreekanth-stripe commented Jan 9, 2026

Docs styling was looking off, likely due to an upgrade to Next.js. This upgrade made it so that styled-jsx was no longer bundled with Next.js, causing styling issues.

Now, I updated the css to explicitly specify styling, to avoid issues of this nature in the future:

Before:
Screenshot 2026-01-06 at 15 25 35 (1)

After:
image

@vercel
Copy link
Contributor

vercel bot commented Jan 9, 2026

@vsreekanth-stripe is attempting to deploy a commit to the Stripe Team on Vercel.

A member of the Team first needs to authorize it.

@vsreekanth-stripe vsreekanth-stripe marked this pull request as ready for review January 9, 2026 00:16
@vercel
Copy link
Contributor

vercel bot commented Jan 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
markdoc Ready Ready Preview, Comment Jan 9, 2026 0:52am
markdoc-simple-nextjs Ready Ready Preview, Comment Jan 9, 2026 0:52am

@mfix-stripe
Copy link
Contributor

@vsreekanth-stripe did this fix the broken styles on the homepage too?

If not, maybe it's worth pinning our Next version to an older version with styled-jsx until that has been migrated.

@vsreekanth-stripe
Copy link
Contributor Author

Ah, no it didn't. I can downgrade our Next version but it was upgraded due to a React vulnerability, so I'm not sure how we'll address that. @mfix-stripe

@mfix-stripe
Copy link
Contributor

Ah, no it didn't. I can downgrade our Next version but it was upgraded due to a React vulnerability, so I'm not sure how we'll address that. @mfix-stripe

Is there no patched version for the older version of Next.js?

@vsreekanth-stripe
Copy link
Contributor Author

vsreekanth-stripe commented Jan 9, 2026

@mfix-stripe According to this, this is the version we were supposed to upgrade to. I'll keep trying to fix it by explicitly importing styled-jsx, but so far I haven't gotten it to work. Do we want to wait to deploy until this PR also fixes the home page?

@vsreekanth-stripe
Copy link
Contributor Author

I did some research, and it looks like the vulnerability only affects App Router applications

Next.js Pages Router applications are not affected.

We should only be using Pages Router, so it should be safe to downgrade again. I'm going to close this PR and open a new one that downgrades the Next version.

@vsreekanth-stripe
Copy link
Contributor Author

Here's the new PR: #128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants