-
Notifications
You must be signed in to change notification settings - Fork 169
Fixed styling for docs #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed styling for docs #127
Conversation
|
@vsreekanth-stripe is attempting to deploy a commit to the Stripe Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@vsreekanth-stripe did this fix the broken styles on the homepage too? If not, maybe it's worth pinning our Next version to an older version with |
|
Ah, no it didn't. I can downgrade our Next version but it was upgraded due to a React vulnerability, so I'm not sure how we'll address that. @mfix-stripe |
Is there no patched version for the older version of Next.js? |
|
@mfix-stripe According to this, this is the version we were supposed to upgrade to. I'll keep trying to fix it by explicitly importing styled-jsx, but so far I haven't gotten it to work. Do we want to wait to deploy until this PR also fixes the home page? |
|
I did some research, and it looks like the vulnerability only affects App Router applications
We should only be using Pages Router, so it should be safe to downgrade again. I'm going to close this PR and open a new one that downgrades the Next version. |
|
Here's the new PR: #128 |
Docs styling was looking off, likely due to an upgrade to Next.js. This upgrade made it so that
styled-jsxwas no longer bundled with Next.js, causing styling issues.Now, I updated the css to explicitly specify styling, to avoid issues of this nature in the future:
Before:

After:
