Fix ServiceWorkerRegistration is not defined (#173)

[gpoole]

Adds an additional check for ServiceWorkerRegistration being defined before trying to access it, allowing the module to be imported in non-browser environments or browsers that don't define ServiceWorkerRegistration.

Fixes #173

[markcellus]

Seems reasonable. Thanks!

[markcellus]

@gpoole before merging this, do you mind creating a test for it? Just want to avoid this being reverted. Test file is located in the test directory and should be pretty easy. Thanks again!

[mspae]

@gpoole @markcellus I'd be willing to help adding a test to get this MR merged. I'm running into the same issue and am currently patching cookie-store which is not ideal obviously. Let me know what you think.

[markcellus]

Yeah pls add tests and repro steps thanks. And will take another look.

I was waiting to see if someone could give me steps to reproduce on my machine so I can verify locally before merging. 👍

[mspae]

Actually can't get the tests to run through at all.

Uncaught TypeError: Cannot set property cookieStore of #<Window> which has only a getter

I' on node v18.17.1. This might be related.

[goto-bus-stop]

ServiceWorkerRegistration is not defined in insecure contexts. It works on HTTPS and on localhost, but if you have an alias in your hosts file (for example i use hserv.local to access my home server where I work on), and you access that through HTTP non-S, ServiceWorkerRegistration is not defined.

Another way to check is using the console on http://example.com (make sure you're not redirected to HTTPS).

I'm not really sure how to add a test for this as it requires deleting the global ServiceWorkerRegistration object before the library is loaded at all, which is not doable in index.tests.js. It needs to run in a completely separate environment.