Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
larkprovider to the current documentation and rename tofeishu.The reason behind the change is that the previous
larkprovider defaults tohttps://open.feishu.cn/open-apis/*endpoint which is forfeishuwhilelark's endpoint is athttps://open.larksuite.com/open-apis/*.larkendpoint can be specified byNewCustomisedURL()however.Also this PR sources
UserIDfromOpenIDinstead ofUserID, which requires an additionalcontact:user.employee_id:readonlyscope, and sourcesEmailfromEnterpriseEmail, which is set up by tenant administrators, instead ofEmail, which is set by users themselves and may not be reliable.Such changes requires more consciously update and rename the provider is necessary IMO.