Skip to content

Please consider the following formatting changes to #12447 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mario-krueger merged 1 commit into from
Aug 6, 2025
Merged

Please consider the following formatting changes to #12447 #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions PWGLF/Tasks/Nuspex/spectraCharged.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,19 @@
// mimics Run1&2 version https://github.com/alisw/AliPhysics/blob/master/PWGLF/SPECTRA/ChargedHadrons/MultDepSpec/AliMultDepSpecAnalysisTask.cxx
// and is compatible with postprocessing https://gitlab.cern.ch/mkruger/unfoldingframework

#include "Framework/HistogramRegistry.h"
#include "ReconstructionDataFormats/Track.h"
#include "Framework/runDataProcessing.h"
#include "Framework/AnalysisTask.h"
#include "Framework/O2DatabasePDGPlugin.h"
#include "Common/DataModel/EventSelection.h"
#include "Common/DataModel/Centrality.h"
#include "Common/DataModel/TrackSelectionTables.h"
#include "Common/Core/TrackSelection.h"
#include "Common/Core/TrackSelectionDefaults.h"
#include "Common/DataModel/Centrality.h"
#include "Common/DataModel/EventSelection.h"
#include "Common/DataModel/TrackSelectionTables.h"

#include "Framework/AnalysisTask.h"
#include "Framework/HistogramRegistry.h"
#include "Framework/O2DatabasePDGPlugin.h"
#include "Framework/runDataProcessing.h"
#include "ReconstructionDataFormats/Track.h"

#include "TDatabasePDG.h"

Check failure on line 28 in PWGLF/Tasks/Nuspex/spectraCharged.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/database] 

Do not use TDatabasePDG directly. Use o2::constants::physics::Mass... or Service<o2::framework::O2DatabasePDG> instead.

using namespace o2;
using namespace o2::framework;
Expand Down Expand Up @@ -158,7 +160,7 @@
}

trackSel = getGlobalTrackSelection();
if (cutMode == 101) {

Check failure on line 163 in PWGLF/Tasks/Nuspex/spectraCharged.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
trackSel.SetMaxChi2PerClusterITS(25.);
cutVarFlag = TrackSelectionFlags::kITSChi2NDF;
trackSelFlag = TrackSelection::TrackCuts::kITSChi2NDF;
Expand All @@ -183,11 +185,11 @@
cutVarFlag = TrackSelectionFlags::kTPCCrossedRowsOverNCls;
trackSelFlag = TrackSelection::TrackCuts::kTPCCrossedRowsOverNCls;
} else if (cutMode == 111) {
trackSel.SetMaxDcaXYPtDep([](float pt) { return 4. / 7. * (0.0105f + 0.0350f / pow(pt, 1.1f)); });

Check failure on line 188 in PWGLF/Tasks/Nuspex/spectraCharged.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[std-prefix] 

Use std:: prefix for names from the std namespace.
cutVarFlag = TrackSelectionFlags::kDCAxy;
trackSelFlag = TrackSelection::TrackCuts::kDCAxy;
} else if (cutMode == 112) {
trackSel.SetMaxDcaXYPtDep([](float pt) { return 10. / 7. * (0.0105f + 0.0350f / pow(pt, 1.1f)); });

Check failure on line 192 in PWGLF/Tasks/Nuspex/spectraCharged.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[std-prefix] 

Use std:: prefix for names from the std namespace.
cutVarFlag = TrackSelectionFlags::kDCAxy;
trackSelFlag = TrackSelection::TrackCuts::kDCAxy;
} else if (cutMode == 113) {
Expand Down Expand Up @@ -248,7 +250,7 @@
if (collisions.size() == 0) {
vars.isAcceptedEvent = false;
} else {
for (auto& collision : collisions) {

Check failure on line 253 in PWGLF/Tasks/Nuspex/spectraCharged.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
auto curTracks = tracks.sliceBy(perCollision, collision.globalIndex());
initEvent(collision, curTracks);
processMeas<true>(collision, curTracks);
Expand Down Expand Up @@ -318,7 +320,7 @@
void chargedSpectra::initEvent(const C& collision, const T& tracks)
{
vars.multMeas = 0;
for (auto& track : tracks) {

Check failure on line 323 in PWGLF/Tasks/Nuspex/spectraCharged.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
if (initTrack(track)) {
++vars.multMeas;
}
Expand All @@ -344,7 +346,7 @@
{
vars.isINELGT0EventMC = false; // will be set to true in case a charged particle within eta +-1 is found
vars.multTrue = 0;
for (auto& particle : particles) {

Check failure on line 349 in PWGLF/Tasks/Nuspex/spectraCharged.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
if (!initParticle(particle) || !vars.isChargedPrimary) {
continue;
}
Expand All @@ -368,7 +370,7 @@

histos.fill(HIST("multDist_evt_gen"), vars.multTrue);

for (auto& particle : particles) {

Check failure on line 373 in PWGLF/Tasks/Nuspex/spectraCharged.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
if (initParticle(particle) && vars.isChargedPrimary) {
histos.fill(HIST("multPtSpec_prim_gen"), vars.multTrue, particle.pt());
if (!vars.isAcceptedEvent) {
Expand Down Expand Up @@ -399,7 +401,7 @@
}

std::vector<int> foundParticles;
for (auto& track : tracks) {

Check failure on line 404 in PWGLF/Tasks/Nuspex/spectraCharged.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.

if (!initTrack(track)) {
continue;
Expand Down Expand Up @@ -444,7 +446,7 @@
}

std::unordered_set<int> uniqueIndices(foundParticles.begin(), foundParticles.end());
for (auto mcParticleID : uniqueIndices) {

Check failure on line 449 in PWGLF/Tasks/Nuspex/spectraCharged.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
histos.fill(HIST("track_ambiguity"), std::count(foundParticles.begin(), foundParticles.end(), mcParticleID));
}
}
Loading