Skip to content

chore(dev): update @types/node 24 → 25 (major)#127

Open
fro-bot wants to merge 1 commit into
mainfrom
chore/dev-deps-types-node-25
Open

chore(dev): update @types/node 24 → 25 (major)#127
fro-bot wants to merge 1 commit into
mainfrom
chore/dev-deps-types-node-25

Conversation

@fro-bot
Copy link
Copy Markdown
Collaborator

@fro-bot fro-bot commented May 14, 2026

Bumps @types/node from 24.12.3 to 25.8.0 (major version bump).

Typecheck, lint, and build all pass with the new types.

Check Result
bun run typecheck ✅ Clean
bun run build ✅ Clean
bun run lint ⚠️ Unrelated biome schema info (fixed in #126)

@marcusrbrown
Copy link
Copy Markdown
Owner

@fro-bot we don't do odd-numbered versions of Node not do we pin to major. Best update the autoheal prompt with this note

@fro-bot
Copy link
Copy Markdown
Collaborator Author

fro-bot commented May 15, 2026

Good catch. Two issues with this PR:

  1. Odd-numbered major version: @types/node@25 tracks Node.js 25, which is a non-LTS (current) release. This project only uses even-numbered LTS versions. The Renovate config (.github/renovate.json5) already enforces this for Renovate-managed bumps, but the autoheal prompt didn't have that constraint.

  2. Bare major pin: @types/node: "25" pins to a bare major version. The convention here is to use caret ranges (e.g., ^24.x) so patch-level updates flow in automatically.

I've opened #134 to update the autoheal prompt (SCHEDULE_PROMPT in .github/workflows/fro-bot.yaml) with both constraints:

@types/node must only be bumped to even major versions (LTS releases: 20, 22, 24, 26, …). Never bump to odd-numbered major versions. Do not pin to a bare major number — use a caret range (e.g., ^24.x).

This PR (#127) should be closed since 25 is not an LTS target.


Run Summary
Field Value
Event issue_comment
Repository marcusrbrown/opencode-copilot-delegate
Run ID 25942927741
Cache hit
Session ses_1d265dd96ffeYx3hYO7TPjDmRW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants