fix: eliminate N+1 query patterns in dependency resolution#73
Open
fix: eliminate N+1 query patterns in dependency resolution#73
Conversation
…dexes Replace 5 N+1 query loops with batch fetches using GetIssuesByIDs and GetIssueStatuses: dependency.GetDependencies, dependency.GetDependents, dependency.getTransitiveBlockedFiltered, db.GetDescendantIssues, and db.cascadeUnblockDependentsLocked. Add composite indexes on issues(implementer_session, status) and issue_dependencies(depends_on_id) via schema migration v30. Add benchmarks for critical paths. Nightshift-Task: perf-regression Nightshift-Ref: https://github.com/marcus/nightshift Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetIssuesByIDs/GetIssueStatuses) independency.GetDependencies,dependency.GetDependents,dependency.getTransitiveBlockedFiltered,db.GetDescendantIssues, anddb.cascadeUnblockDependentsLockedidx_issues_impl_statusandidx_deps_depends_onvia schema migration v30GetDescendantIssues,GetDependencies/GetDependents,GetTransitiveBlocked, andCascadeUnblockDependentsTest plan
go test ./...— 29 packages)🤖 Generated with Claude Code
Automated by nightshift