fix: harden security anti-patterns across codebase#67
Open
Conversation
- Use crypto/subtle.ConstantTimeCompare for auth token comparison to prevent timing-attack side channels (server.go) - Add entity type allowlist validation in sync events to prevent SQL injection via entityType interpolation (events.go) - Add table name regex validation in migration helpers to prevent SQL injection via PRAGMA/DDL interpolation (migrations.go) - Validate editor binary exists in PATH before exec (note.go, form_operations.go) Nightshift-Task: security-footgun Nightshift-Ref: https://github.com/marcus/nightshift Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
==token comparison withcrypto/subtle.ConstantTimeComparein auth middleware (server.go)validEntityTables) inevents.gosoentityTypeis validated against known table names before interpolation into SQL — defense-in-depth beyond the caller'sEntityValidatorvalidTableNameregex checks inmigrations.gofor all functions that interpolate table names into PRAGMA/DDL statementsexec.LookPathbefore exec innote.goandform_operations.go, with clear error messagesTest plan
go test ./...— 0 failures)TestApplyEvent_InvalidEntityTypecovers rejection of unknown entity typesgo build)🤖 Generated with Claude Code
Automated by nightshift