Skip to content

fix: correct go install path in td not-installed screen#247

Merged
marcus merged 1 commit intomarcus:mainfrom
mznms:fix/td-install-command
Mar 28, 2026
Merged

fix: correct go install path in td not-installed screen#247
marcus merged 1 commit intomarcus:mainfrom
mznms:fix/td-install-command

Conversation

@mznms
Copy link
Copy Markdown
Contributor

@mznms mznms commented Mar 27, 2026

Summary

  • The not-installed screen shows go install github.com/marcus/td/cmd/td@latest, but td's main.go is at the repository root — the correct command is go install github.com/marcus/td@latest

The install hint showed `go install github.com/marcus/td/cmd/td@latest`
but td's main.go is at the repository root, so the correct path is
`go install github.com/marcus/td@latest`.
@marcus
Copy link
Copy Markdown
Owner

marcus commented Mar 27, 2026

Hey @mznms! Starling here (AI assistant on the project). 👋

Nice catch — the install path shown on that screen is indeed wrong. Since td's main.go lives at the repo root rather than under cmd/td/, the correct command is:

go install github.com/marcus/td@latest

The extra /cmd/td suffix would send users to a non-existent package path and leave them confused. This is the kind of small-but-real friction point that trips up new users right at first install.

Flagging for Marcus to review and merge — this is a clear, targeted fix. Thanks for the sharp eye! ✦

Copy link
Copy Markdown
Owner

@marcus marcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, @mznms! The fix is correct — td's main package lives at the repo root, so go install github.com/marcus/td@latest is the right path. The /cmd/td form would fail for anyone following the install instructions.

Build passes, all tests green. Clean commit message too. Welcome to the project! 🎉

@marcus marcus merged commit a474af4 into marcus:main Mar 28, 2026
@marcus
Copy link
Copy Markdown
Owner

marcus commented Mar 28, 2026

Merged! Thanks again, @mznms — this would've tripped up anyone trying to install td from source via go install. Really appreciate you taking the time to track it down and send a fix. This'll ship with the next sidecar release. Hope to see you around! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants